Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added command: getex #1358

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Added command: getex #1358

merged 5 commits into from
Jan 31, 2025

Conversation

SomajitDey
Copy link
Contributor

@SomajitDey SomajitDey commented Jan 31, 2025

Added the command getex along with the necessary test file.

bun test getex gives:

bun test v1.1.38 (bf2f153f)

pkg/commands/getex.test.ts:
✓ without options > gets value [1031.03ms]
✓ ex > gets value and sets expiry in seconds [2847.04ms]
✓ px > gets value and sets expiry in milliseconds [2848.68ms]
✓ exat > gets value and sets expiry in Unix time (seconds) [3841.88ms]
✓ pxat > gets value and sets expiry in Unix time (milliseconds) [3829.22ms]
✓ persist > gets value and removes expiry [2825.41ms]

 6 pass
 0 fail
 17 expect() calls
Ran 6 tests across 1 files. [17.51s]

The following tests also passed:
bun test redis_getex
bun test pipeline

Copy link
Contributor

@CahidArda CahidArda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@CahidArda CahidArda merged commit a08f1ca into upstash:main Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants