Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

paste truncated output in non pravite chats #87

Closed
wants to merge 5 commits into from

Conversation

mokurin000
Copy link

fix #86, naive implementation

src/eval/execute.rs Outdated Show resolved Hide resolved
src/eval/execute.rs Outdated Show resolved Hide resolved
src/eval/execute.rs Outdated Show resolved Hide resolved
src/eval/execute.rs Outdated Show resolved Hide resolved
src/eval/execute.rs Outdated Show resolved Hide resolved
src/eval/execute.rs Outdated Show resolved Hide resolved
src/eval/execute.rs Show resolved Hide resolved
@mokurin000 mokurin000 marked this pull request as draft June 17, 2023 16:07
src/eval/execute.rs Show resolved Hide resolved
@mokurin000 mokurin000 marked this pull request as ready for review June 21, 2023 13:00
@upsuper
Copy link
Owner

upsuper commented Jul 21, 2023

Thanks for the PR and review, and sorry for the delay.

I would like not to include this feature for several reasons.

First of all, the eval bot is mainly for small quick demonstration / experiment within Telegram, and most of its features are designed with that in mind (e.g. more comprehensive prelude, adaptive template, Unicode auto-replacement). For these purposes, it should be very rare that one would need to produce a long result, and the truncation is put there mostly as a measure to restrict incidental or malicious bombing in group chat. For other purposes, it should generally be easier to manage through other approach, e.g. using the playground directly or cargo-play.

In addition, this enables persisting user-generated information on an external service via this bot, which can be undesirable on its own for reasons including:

  • it's harder for the author to remove the information if it is found sensitive after being posted, and
  • it's harder for the service to track and block abuse if this bot is used as a proxy.

Furthermore, the extra request to a separate service and relying on its functioning to work properly can have negative impact for reliability and responsiveness of the bot itself. It might not be a big issue itself given it doesn't serve the main use case, though.

Given the reasons above, I'm going to close this PR. We can discuss about alternatives for #86 if you have concrete examples in mind that may benefit from such features, and doesn't have issues above, especially around persistence of user-generated information.

@upsuper upsuper closed this Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow group admin set truncate policy for group, also individual could set their prefer
3 participants