Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to clang-format-11 (and friends) #53

Closed
cajun-rat opened this issue Jan 18, 2022 · 1 comment
Closed

Upgrade to clang-format-11 (and friends) #53

cajun-rat opened this issue Jan 18, 2022 · 1 comment

Comments

@cajun-rat
Copy link
Collaborator

At the moment Aktualizr uses clang-format-10 for formatting. We have to stick to one release to avoid different versions 'fighting' each other.

Debian Stable is currently on clang-format-11, but doesn't ship clang-format-10 which motivated me to look at an upgrade.

Aktualizr uses Ubuntu Focal (I think) for formatting checks, which has has clang-format-11.

From my initial trials, the only formatting that has changed is that Args &&... args will drop the second space to become Args &&...args

@pattivacek
Copy link
Collaborator

From my initial trials, the only formatting that has changed is that Args &&... args will drop the second space to become Args &&...args

Correct. And there are no changes from clang-format-11 and clang-format-12 by default. I don't particularly like the args change, and it's really annoying that there's no option for controlling it, and it's explicitly backwards-incompatible, so once we upgrade, anyone using older versions will conflict with the new version. Pretty bad work there, which is not usually what I expect from clang. (See here for some further insight.)

Anyway, at this point, it sounds like less of a pain to just upgrade and deal with it, since it's now causing problems to not upgrade.

cajun-rat added a commit to cajun-rat/aktualizr that referenced this issue Jan 22, 2022
See uptane/aktualizr#53

I chose clang-format-11 because is in both (current) Debian Stable and Ubuntu
Focal.

Signed-off-by: Phil Wise <phil@phil-wise.com>
cajun-rat added a commit to cajun-rat/aktualizr that referenced this issue Jan 22, 2022
See uptane/aktualizr#53

I chose clang-format-11 because is in both (current) Debian Stable and Ubuntu
Focal.

Signed-off-by: Phil Wise <phil@phil-wise.com>
cajun-rat added a commit to cajun-rat/aktualizr that referenced this issue Jan 22, 2022
See uptane/aktualizr#53

I chose clang-format-11 because is in both (current) Debian Stable and Ubuntu
Focal.

Signed-off-by: Phil Wise <phil@phil-wise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants