Explain why custom URIs should be preferred over multiple image repos #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jon Oster <jon.oster@here.com>
trishankatdatadog
requested changes
Sep 1, 2020
There was a problem hiding this comment.
Seems reasonable to me, as long as the metadata from the Image Repository is trustworthy.
I would ask just to clarify that this has nothing to do with the Director Repository, just the idea of using multiple Image Repositories to accommodate literally different servers for images.
|
LGTM, but our style guide is to capitalize "Image repository" and "Director repository". |
jhdalek55
requested changes
Sep 2, 2020
|
@tkfu --There are a few small wording suggestions that need to be resolved. Can we get this done? |
Co-authored-by: Lois Anne DeLong <lad278@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to the discussion of #4. This PR just adds some guidance on how to deal with the situation where you have multiple existing repositories, by recommending using a single image repo to serve all the metadata while offering up download locations either via API/HTTP redirects or via custom targets metadata.
Signed-off-by: Jon Oster jon.oster@here.com