Remove soup from PACKAGECONFIG only if ptest is not enabled #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the first patch to include your signed-off-by and drop the second and the third, not needed. Can you also change the commit message to be 'ostree: remove soup...', easier to identify that this change is specific to the ostree recipe. |
quic-roshs
force-pushed
the
quic-roshs-patch-1
branch
2 times, most recently
from
a055a23 to
67afb95
Compare
|
Hi Ricardo, Thanks for the comments. Made all the changes. |
|
@quic-roshs minor thing, can you update your author line to have your name instead? It is currently: |
ostree-ptest has a dependency on ostree-trivial-httpd which gets compiled only if soup is enabled. Signed-off-by: Roshan Sivakumar <quic_roshs@quicinc.com>
quic-roshs
force-pushed
the
quic-roshs-patch-1
branch
from
3d3a220 to
b10153c
Compare
|
Done |
quic-roshs
pushed a commit
to quic-roshs/meta-updater
that referenced
this pull request
Aug 28, 2024
f88fb5fae (HEAD -> master, origin/master, origin/HEAD) Merge pull request uptane#112 from uptane/fix/garage-cli cf48737d1 Fetch garage-sign from a new location 3662ed09e Merge pull request uptane#108 from cajun-rat/correlation-id 45047239d Add default to load installed version with correlation id 146d347d8 Move CorrelationID up a level out of Target dad1cbe27 Merge pull request uptane#109 from cajun-rat/various-tidy cdc604ba1 Merge pull request uptane#110 from uptane/header-fix 13e9eb4f0 Merge pull request uptane#111 from uptane/docs/contributing febb95cce Docs: Update CONTRIBUTING to reflect new policies c0bf7314f Add missing include cc33025e1 Various tidy-ups 513aadfaf Merge pull request uptane#107 from cajun-rat/more-flow-control 91ead679b Introduce finer-grained cancellation of operations Signed-off-by: Jose Manuel Diez <j.diezlopez@tu-berlin.de> (cherry picked from commit 2a83537) Signed-off-by: Eduardo Ferreira <eduardo.barbosa@toradex.com>
EdTheBearded
pushed a commit
to EdTheBearded/meta-updater
that referenced
this pull request
Oct 30, 2024
f88fb5fae (HEAD -> master, origin/master, origin/HEAD) Merge pull request uptane#112 from uptane/fix/garage-cli cf48737d1 Fetch garage-sign from a new location 3662ed09e Merge pull request uptane#108 from cajun-rat/correlation-id 45047239d Add default to load installed version with correlation id 146d347d8 Move CorrelationID up a level out of Target dad1cbe27 Merge pull request uptane#109 from cajun-rat/various-tidy cdc604ba1 Merge pull request uptane#110 from uptane/header-fix 13e9eb4f0 Merge pull request uptane#111 from uptane/docs/contributing febb95cce Docs: Update CONTRIBUTING to reflect new policies c0bf7314f Add missing include cc33025e1 Various tidy-ups 513aadfaf Merge pull request uptane#107 from cajun-rat/more-flow-control 91ead679b Introduce finer-grained cancellation of operations Signed-off-by: Jose Manuel Diez <j.diezlopez@tu-berlin.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working to enable ostree in my yocto build using meta-updater.
I see a build issue related to ostree-ptest when ptest is enabled as part of the distro features. It seems like ostree-ptest has a dependency on ostree-trivial-httpd and it breaks on removing soup from PACKAGECONFIG.
This change is to remove soup only if ptest is not enabled.
Build, boot up and ota update are successful with this change.