Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Standard currently requires all metadata to be downloaded on each update check #147

Closed
tkfu opened this issue Oct 29, 2019 · 8 comments · Fixed by #151
Closed

Bug: Standard currently requires all metadata to be downloaded on each update check #147

tkfu opened this issue Oct 29, 2019 · 8 comments · Fixed by #151
Assignees

Comments

@tkfu
Copy link
Member

tkfu commented Oct 29, 2019

As currently written, the standard says that all four metadata files from both repositories must be downloaded every time a vehicle checks for updates. This shouldn't be necessary:

  • When we download the timestamp metadata, it contains a hash of the snapshot metadata file; if the current snapshot file we have on disk matches that hash, we don't need to re-download it.
  • Similarly, the snapshot metadata lists the current version numbers of all targets metadata files; if snapshot metadata tells us that the version of the top-level targets metadata file we already have on disk is the latest one, there's no reason to re-download it.

Is there anything wrong with this reasoning? Do we actually need to re-download metadata that we already have? And if not, how should we go about publishing this erratum, given that the IEEE-ISTO organization no longer exists?

@tkfu
Copy link
Member Author

tkfu commented Oct 29, 2019

Note that this is an important issue for automotive OEMs, especially U.S.-American ones; minimizing mobile data transfer is often a key concern when evaluating any connected car services. Top-level targets metadata, especially, can sometimes be quite large depending on repository management and delegation choices.

@trishankatdatadog
Copy link
Member

Yeah, this should be clarified.

@iramcdonald
Copy link

iramcdonald commented Oct 29, 2019 via email

@pattivacek
Copy link
Collaborator

A third point that we discussed but isn't mentioned here: there's no need to download anything from the Image repo if the Director indicates there are no new updates to install.

@JustinCappos
Copy link
Contributor

It may not be the most important thing but downloading the image repo's timestamp and snapshot is still helpful from a security standpoint in this case. It helps to prevent / limit mix-and-match attacks later...

@tkfu
Copy link
Member Author

tkfu commented Oct 30, 2019

That could be a MAY or a SHOULD though, right? Or left to deployment considerations?

@jhdalek55
Copy link
Contributor

i think actually two things require actions here. The first is correcting the error and the second is how we post the errata.

@tkfu would you be able to write up the PR to address the former? And can @JustinCappos and/or @iramcdonald suggest how we handle the errata?

@pattivacek
Copy link
Collaborator

I've pushed a PR with a fix for this, with the optimizations given as MAYs to accommodate @JustinCappos's suggestion that downloading the Image repo's Timestamp and Snapshot may actually be useful. However, I realized the top-level targets metadata file is not currently possible. Please see the PR for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants