Skip to content
This repository was archived by the owner on Jan 27, 2025. It is now read-only.

Conversation

tmarcinkowski-logitech
Copy link
Contributor

@tmarcinkowski-logitech tmarcinkowski-logitech commented Jun 15, 2021

Description

  • updateFilter function - exposed
  • function to actually do the filtering - exposed (I needed to filter by the basename only)
  • clicking on a folder in the search results view, opens it instead of toggling its state (implies the next change)
  • all folders in the search results view are displayed as closed
  • flattening of search results made optional

Changelog

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • I actively use it in my codebase

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@dreadera dreadera self-requested a review June 17, 2021 10:40
Copy link
Contributor

@dreadera dreadera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution :)
My only feedback is that the naming convention for files is kebab-case

So instead of defaultLogic.js It should be default-logic.js

@tmarcinkowski-logitech
Copy link
Contributor Author

Great! I fixed the filename and added one more additional commit so please take a look at the whole again :)

@tmarcinkowski-logitech tmarcinkowski-logitech changed the title Filter improvements feature: Filter improvements Jun 21, 2021
@dreadera dreadera removed their request for review February 1, 2022 05:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants