-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using web tools component #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PalumboN
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tale tale tale 🪵 🪓
package.json
Outdated
@@ -61,9 +62,10 @@ | |||
"socket.io": "^4.5.1", | |||
"winston": "^3.11.0", | |||
"wollok-ts": "4.1.6", | |||
"wollok-web-tools": "1.1.2" | |||
"wollok-web-tools": "file:../wollok-web-tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actualizar después de releasear tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hay que releasear wollok-web-tools, pero algunas cosas que metí en este PR
game-index
ydiagram-index
, se copian a public para poder ser usados/public
y se copian a/dist/public
no hay que hacer
import { getDataDiagram } from 'wollok-web-tools/dist/dynamicDiagram/diagram-generator'
Variable
y dice que no. Eso causa que las referencias del REPL no aparezcan (solo aparecen los objetos):En el util llamo desde ts-cli directamente a
wollok-ts
y obtengo los objetos para después llamar awollok-web-tools
con esos objetos.diagram-index.js
asume que existecytoscape
importado dentro del html, se copia en el npm install y listop5
yp5sound
como minificadas, pensé en un momento que faltaba hacer eso pero solamente tenían el nombre normal.diagram-generator.ts
que adapta la información como viene de wollok-ts a lo que cytoscape necesita. También se elimina el archivodiagram.js
que se renombra adiagram-index.js
. Ambos archivos ahora están bajo la órbita dewollok-web-tools
para poder reutilizarse en el sitio web.