Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests/test_check.py py.test friendly #162

Closed
wants to merge 1 commit into from

Conversation

lesteve
Copy link

@lesteve lesteve commented Mar 16, 2016

First go at tackling #139 one file at a time.

Adding __init__.py in the tests folder is a convenience so that you can do py.test tests/test_check.py. It seems to be a convention in all the projects I have worked with too (numpy, scipy, scikit-learn, etc ...).

@lesteve
Copy link
Author

lesteve commented Apr 4, 2016

@mmckerns any comments on this one? I completely understand if you don't have much time on your hand but I would have thought this PR would be a quick one to review ...

Just as a reminder the end goal is to be able to run tests with py.test and further down the line to have CI testing on PRs via Travis.

@lesteve
Copy link
Author

lesteve commented Apr 19, 2016

gentle ping @mmckerns.

@lesteve
Copy link
Author

lesteve commented May 4, 2016

Any comments on this one @mmckerns?

@mmckerns
Copy link
Member

mmckerns commented May 4, 2016

@lesteve: sorry I've been swamped for about a month. I will most likely take this PR as is. I prepped an environment to test it, and looked at how others are using py.test… but I've been stuck there for a while. This is of the first things I'll do once I am no longer on fire.

@lesteve
Copy link
Author

lesteve commented May 4, 2016

OK thanks for your reply. I'll try to gather some momentum to tackle other files in a similar way, so that they are py.test friendly as well.

@mmckerns mmckerns mentioned this pull request Jun 10, 2016
@Peque Peque mentioned this pull request Dec 17, 2016
@mmckerns
Copy link
Member

@lesteve: I'm going to mark this as duplicate to #198, as #198 handles it in a way uniform to other of the tests. Thanks for your contribution… sorry it took me this long to get to it… and please don't hesitate to help out on the pytest test-runner portion of PR #198.

@mmckerns mmckerns closed this Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants