Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable logging propagation, use current stderr as output #541

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

leogama
Copy link
Contributor

@leogama leogama commented Aug 11, 2022

  1. Propagation can create duplicate messages if the root logger has stdout/stderr handlers set (as observed in Pickling class instance in dict fails unless you try pickling the object directly first #540).
  2. StreamHandler() uses the sys.stderr value as of the time of handler creation, _StderrHandler() always use the current value of sys.stderr.

1. Propagation can create duplicate messages if the root logger has stdout/stderr handlers set (as observed in uqfoundation#540).
2. `StreamHandler()` uses the `sys.stderr` value as of the time of handler creation, `_StderrHandler()` always use the current value of `sys.stderr`.
@mmckerns mmckerns added this to the dill-0.3.6 milestone Aug 11, 2022
@mmckerns mmckerns merged commit 1d3e8cf into uqfoundation:master Aug 11, 2022
@leogama leogama deleted the patch-2 branch August 11, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants