Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 Metaclasses [Support ABC and Enums - Part 1] #577

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

anivegesana
Copy link
Contributor

This PR is part 1 of the broken down version of #450. It extends support of metaclass pickling to features added in Python 3.0, 3.6, and 3.7 (https://peps.python.org/pep-3115/, https://peps.python.org/pep-0487/, https://peps.python.org/pep-0560/).

@anivegesana
Copy link
Contributor Author

I think the coverage issue can be ignored. The coverage passes in #450 and it is failing here because the ABC and enum tests are not in this PR.

@anivegesana
Copy link
Contributor Author

@mmckerns Should I add test cases that test this feature without using enums or ABCs, or is this feature ready for review?

@mmckerns
Copy link
Member

mmckerns commented Mar 5, 2023

Please always request a review when you feel a PR is ready to be reviewed. Otherwise, it's hard to know what the state of the PR is. The general rule is that you should always add tests cases, unless the change is trivial.

@anivegesana
Copy link
Contributor Author

I think that I don't have the permissions to request a review. I am just marking PRs that aren't ready for review as drafts. Will create test cases for these features to improve coverage.

@anivegesana anivegesana marked this pull request as draft March 5, 2023 04:54
@anivegesana anivegesana marked this pull request as ready for review March 5, 2023 05:05
@anivegesana
Copy link
Contributor Author

@mmckerns It should be ready for review now.

Copy link
Member

@mmckerns mmckerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmckerns mmckerns merged commit 322cf1b into uqfoundation:master Mar 8, 2023
@anivegesana anivegesana mentioned this pull request Mar 8, 2023
@anivegesana
Copy link
Contributor Author

The size of this PR seems to be more manageable. I will make the remaining PRs roughly the same size. This PR merged 148/599 changed lines (additions/deletions), so we have merged 1 out of 4 PRs need for supporting ABCs and Enums. 🎉

This is sizable progress. @mmckerns, hope that this plan isn't too cumbersome.

@mmckerns
Copy link
Member

mmckerns commented Aug 19, 2023

note does not seem to close #250 [i.e. enum are not yet supported)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants