Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type check for Integral, bool by value #77

Merged
merged 1 commit into from
Sep 9, 2024
Merged

type check for Integral, bool by value #77

merged 1 commit into from
Sep 9, 2024

Conversation

mmckerns
Copy link
Member

@mmckerns mmckerns commented Sep 9, 2024 •
edited
Loading

Summary

replace check for isinstance of int with Integral, and isinstance for bool with check for True and False

Checklist

Documentation and Tests

  • Added relevant tests that run with python tests/__main__.py, and pass.
  • Added relevant documentation that builds in sphinx without error.
  • Artifacts produced with the main branch work as expected under this PR.

Release Management

  • Added rationale for any breakage of backwards compatibility.

@mmckerns mmckerns added this to the pyina-0.3.0 milestone Sep 9, 2024
@mmckerns mmckerns merged commit 31b83e3 into master Sep 9, 2024
3 of 4 checks passed
@mmckerns mmckerns deleted the integral branch September 9, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compatibility
Projects
None yet
Milestone
pyina-0.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mmckerns