Intelligent wrap #26
Merged
Intelligent wrap #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple performance checking indicates this is around 1.1 ± 0.2 times slower than before. I think it doesn't matter as much as the feature does, though.
I might investigate adding a flag for fast printing without that. The binary is already huge (from library code I think) so duplicating the functions a few times probably won't affect it too much.
I will also look into adding a flag for word wrapping, so that space-separated strings are always printed on the same line when possible. That seems useful for human-readable use. I'm not sure if I should make it default though - it will be probably be significantly slower.