Improve direct URL upgrade #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing a candidate specified with version requirements over a direct URL installed distribution, force reinstallation if --upgrade was specified. If --upgrade was not specified, reinstall only if the version does not match.
sbidoul
commented
Jun 24, 2022
| @@ -280,6 +280,9 @@ def _get_installed_candidate() -> Optional[Candidate]: | |||
| # the current dependency graph. | |||
| if not specifier.contains(installed_dist.version, prereleases=True): | |||
| return None | |||
| if installed_dist.direct_url or installed_dist.editable: | |||
| # Defer to _get_ireq. | |||
| return None | |||
There was a problem hiding this comment.
This is not correct... perhaps we should defer to _get_ireq only when --upgrade is specified.
uranusjr
force-pushed
the
explicit-url-upgrade-sbi
branch
from
7690d52 to
898057b
Compare
|
Changes incorported into 32824c8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.