Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed dependencies from buildings schema #224

Merged
merged 4 commits into from
May 4, 2022
Merged

removed dependencies from buildings schema #224

merged 4 commits into from
May 4, 2022

Conversation

rawadelkontar
Copy link
Contributor

Resolves #[issue number here]

Pull Request Description

[description here]

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • Documentation has been modified appropriately
  • All ci tests pass (green)
  • An issue has been created (which will be used for the changelog)
  • This branch is up-to-date with develop

@rawadelkontar rawadelkontar requested a review from kflemin May 4, 2022 06:31
kflemin
kflemin approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! can you just add an empty line at the bottom of the site_properties file and building properties.json file and then this can be merged. thanks!

@rawadelkontar rawadelkontar requested a review from kflemin May 4, 2022 16:41
@kflemin kflemin merged commit 9c7f3b8 into develop May 4, 2022
@kflemin kflemin deleted the emissions_fix branch May 4, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflemin kflemin kflemin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rawadelkontar @kflemin