Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OpenStudio 3.7 #265

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Support OpenStudio 3.7 #265

merged 10 commits into from
Jan 9, 2024

Conversation

vtnate
Copy link
Collaborator

@vtnate vtnate commented Nov 20, 2023

Resolves #[issue number here]

Pull Request Description

[description here]

Checklist (Delete lines that don't apply)

  • Unit tests have been added or updated
  • Documentation has been modified appropriately
  • All ci tests pass (green)
  • An issue has been created (which will be used for the changelog)
  • This branch is up-to-date with develop

@vtnate vtnate added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 20, 2023
@vtnate vtnate self-assigned this Nov 20, 2023
@vtnate vtnate marked this pull request as ready for review December 21, 2023 20:24
@vtnate vtnate requested a review from kflemin December 21, 2023 20:24
@vtnate vtnate marked this pull request as draft December 21, 2023 20:27
@vtnate vtnate removed the request for review from kflemin December 21, 2023 20:27
@vtnate
Copy link
Collaborator Author

vtnate commented Dec 21, 2023

Waiting on urbanopt/urbanopt-core-gem#56 to be merged and then released to rubygems

@vtnate vtnate marked this pull request as ready for review January 8, 2024 23:13
@vtnate vtnate requested a review from kflemin January 8, 2024 23:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7454363971

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.31%
Totals Coverage Status
Change from base Build 6020916715: 0.0%
Covered Lines: 805
Relevant Lines: 922
💛 - Coveralls

@vtnate vtnate requested review from kflemin and removed request for kflemin January 8, 2024 23:17
@vtnate vtnate merged commit fe3b040 into develop Jan 9, 2024
1 check passed
@vtnate vtnate deleted the os37 branch January 9, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kflemin kflemin kflemin approved these changes

Assignees

@vtnate vtnate

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtnate @kflemin