Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Other Fuel emission factors update #153

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Other Fuel emission factors update #153

merged 6 commits into from
Jun 24, 2024

Conversation

rawadelkontar
Copy link
Collaborator

Updated the emission factors for other fuel types from the 20-year GWP horizon based on ASHRAE 189.1 to using the new portfolio manager: https://portfoliomanager.energystar.gov/pdf/reference/Emissions.pdf

nat_gas_val = 181.7 KG/MWH
lpg_val = 219.2 KG/MWH
fo1_val = 250.8 KG/MWH
fo2_val = 253.2 KG/MWH

@rawadelkontar rawadelkontar requested a review from kflemin June 18, 2024 06:49
@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9603381243

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.44%
Totals Coverage Status
Change from base Build 8980147760: 0.0%
Covered Lines: 1174
Relevant Lines: 1767
💛 - Coveralls

@vtnate vtnate self-requested a review June 20, 2024 19:53
vtnate
vtnate approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@vtnate vtnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic versioning soapbox! @kflemin 😆 😡

Gemfile
@@ -15,6 +15,8 @@ allow_local = ENV['FAVOR_LOCAL_GEMS']
gem 'addressable', '2.8.1'
# pin this dependency to avoid using racc dependency (which has native extensions)
gem 'parser', '3.2.2.2'
# pin this dependency because 2.9.2 breaks OS tests (openstudio:test_with_openstudio)
gem 'regexp_parser', '2.9.0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible (hopeful) that this requirement will not be required in the future.

@kflemin kflemin merged commit 295ccd1 into develop Jun 24, 2024
@kflemin kflemin deleted the emissions_fix branch June 24, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtnate vtnate vtnate approved these changes

@kflemin kflemin kflemin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rawadelkontar @coveralls @kflemin @vtnate