Remove most instances of strcpy and sprintf

[mrdomino]

OpenBSD whines about these and recommends using strlcpy / snprintf
instead. Since strlcpy isn't quite universal yet, we use strncpy instead
and be careful about terminating the string. We could implement a
portable strlcpy in terms of strncpy, but that'd add another function to
the namespace.

Yes, usually the length is obviously bounded. Still, pretending
strcpy/sprintf don't exist seems like a great strategy.

N.B. there are still a few occurrences of strcpy and sprintf under f/
and in libuv, but I don't have time to tackle them right now.

[cgyarvin]

Super awesome. Super awesome squared...

On Wed, Oct 30, 2013 at 12:31 PM, Steve Dee notifications@github.comwrote:

OpenBSD whines about these and recommends using strlcpy / snprintf
instead. Since strlcpy isn't quite universal yet, we use strncpy instead
and be careful about terminating the string. We could implement a
portable strlcpy in terms of strncpy, but that'd add another function to
the namespace.

Yes, usually the length is obviously bounded. Still, pretending
strcpy/sprintf don't exist seems like a great strategy.

N.B. there are still a few occurrences of strcpy and sprintf under f/

and in libuv, but I don't have time to tackle them right now.

You can merge this Pull Request by running

git pull https://github.com/mrdomino/urbit master

Or view, comment on, or merge it at:

urbit/urbit#71
Commit Summary

• Remove most instances of strcpy and sprintf

File Changes

• M f/coal.c https://github.com/urbit/urbit/pull/71/files#diff-0(8)
• M v/ames.c https://github.com/urbit/urbit/pull/71/files#diff-1(2)
• M v/http.c https://github.com/urbit/urbit/pull/71/files#diff-2(6)
• M v/loop.c https://github.com/urbit/urbit/pull/71/files#diff-3(18)
• M v/main.c https://github.com/urbit/urbit/pull/71/files#diff-4(5)
• M v/reck.c https://github.com/urbit/urbit/pull/71/files#diff-5(6)
• M v/term.c https://github.com/urbit/urbit/pull/71/files#diff-6(3)
• M v/unix.c https://github.com/urbit/urbit/pull/71/files#diff-7(18)
• M v/walk.c https://github.com/urbit/urbit/pull/71/files#diff-8(8)

Patch Links:

• https://github.com/urbit/urbit/pull/71.patch
• https://github.com/urbit/urbit/pull/71.diff