-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should update web3 (toWei errors in minified builds only) #410
Comments
it seems from what ive heard in discord this happens on all eth transactions right now. this same kind of issue was also present in the release build on github in v2.3.3 |
the solution ive been reccomending to people has been to try using v1.4.1 since i dont think azimuth has changed since then and it should work for most stuff |
That's so weird, I use hosted bridge A LOT (which is latest) and have never
seen this. Would love to hear what tx people are running to see this.
—
~poldec-tonteg
http://urbit.org
…On Wed, Mar 11, 2020 at 12:44 PM reitrace ***@***.***> wrote:
the solution ive been reccomending to people has been to try using v1.4.1
since i dont think azimuth has changed since then and it should work for
most stuff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#410 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMJBY46XJRVRFDRWUFAEDDRG7SY3ANCNFSM4LF4GPXQ>
.
|
@reitraced I generally accept invites, transfer, accept transfers (10x/week) with no issues. Have you heard of anyone hitting issues doing that? Or is it only setting/resetting networking keys? |
most of the issues ive seen on discord are with reticketing, breaching, or setting keys. |
Able to repro this on deployed versions, but not when running locally. Investigating further... |
I was able to repro on a locally built one. |
Good god... The issue seems to go away when running a non-minimized build. It does occur for production, and locally run builds, but doesn't occur for I'm... gonna go ahead and push a non-minimized build to prod to help resolve this. We should probably be brave and investigate why minimizing the JS borks these functions. |
(For those following along: deploy done. Look for |
The problem is discussed here and fixed here. toWei checks the In other words just javascript things. Can't really think of a sane way to fix this without upgrading web3-utils, which is spooky. Couldn't find any webpack options to disable mangling of specific classes either. |
Good refs, thanks a bunch @pkova. We should probably look into upgrading web3-utils, then. Hope they went easy with the breaking changes. |
The text was updated successfully, but these errors were encountered: