Ensure we generate the keyfile for latest-set keys #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than latest-seen. Chain might not keep up with user actions, and even if it does, if user navigates to keyfile screen straight away, it won't know about the change yet. This was only a problem for UHD-derived networking keys, since the randomly generated ones were pulled out of cache. Fixes #137.
|
Is that...a steamboat?
—
~poldec-tonteg
http://urbit.org
…On Thu, May 16, 2019 at 4:39 PM Jared Tobin ***@***.***> wrote:
***@***.**** approved this pull request.
🚢
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#138?email_source=notifications&email_token=AAMJBY2RYECLD2OA7UT7HBDPVXWCVA5CNFSM4HNQE4J2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBY5A2SI#pullrequestreview-238685513>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMJBY67NCND3P4JECQWPSTPVXWCVANCNFSM4HNQE4JQ>
.
|
|
ship it . via steamboat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rather than latest-seen. Chain might not keep up with user actions, and even if it does, if user navigates to keyfile screen straight away, it won't know about the change yet. Fixes #137.
This was only a problem for UHD-derived networking keys, since the randomly generated ones were pulled out of cache.
This PR also includes an updated azimuth-js, which we actually need for the fancy new auto-complete on the "issue child" page. Currently, it just crashes there. (^:
Will push out a release once this gets approved/merged.