Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite error msg enhancement & fromWei augmentation #376

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented Jan 30, 2020

Two unrelated commits:

  • e88f47e makes sure we display the relevant email address when we tell the user it has already received an invite before. Note that receiving multiples of these, as is now possible, prints as a single-line concatenated string. The form validator should be printing these errors on their own lines.
  • I still have not been able to reproduce Error Report: Please pass numbers as strings or BigNumber objects to avoid precision errors. #373 and friends locally. One report indicated this happening specifically with a higher amount of to-send invites, but this works fine when I test it. c53aba4 nevertheless wraps all fromWei and toWei calls in a function that does the toBN, and includes additional information in the error report in case of unexpected failure. If the issue continues to rear its ugly head, this should give us some more details to work with. I'll also make sure to deploy a build with non-minimized function names.

These always convert the number argument toBN, and include extra details
in the error message of failing cases.
Copy link
Member

@liam-fitzgerald liam-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Fang- Fang- merged commit 6ae4f03 into master Jan 31, 2020
@Fang- Fang- deleted the m/augment branch January 31, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants