Move common transaction state/mutations into statelessTransaction #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you forgot (to commit) CreateGalaxy.js! Apologies if this is a WIP PR, noticed this since I'm doing some work on #93 but realized I better wait for this one to be merged. |
Fang-
reviewed
Apr 4, 2019
| } | ||
| }); | ||
| this.createUnsignedTxn = this.createUnsignedTxn.bind(this) | ||
| this.statelessRef = React.createRef(); |
There was a problem hiding this comment.
The React docs say you need to add a ref attribute to some DOM element for this to work? I know this ends up with having a pointer to the StatelessTransaction in statelessRef.current, but how does that hook up? I don't see it happen anywhere.
There was a problem hiding this comment.
Ah, good catch! I missed this one. It's there now.
|
Indeed I did @pkova! It's updated now. |
Fang-
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cuts down on the state mutation boilerplate for executing transactions by moving all the common transaction details into statelessTransaction.js