Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ames: forward iff we're a galaxy #493

Merged
merged 1 commit into from
Jul 14, 2023
Merged

ames: forward iff we're a galaxy #493

merged 1 commit into from
Jul 14, 2023

Conversation

matthew-levan
Copy link
Contributor

Resolves #492.

@matthew-levan
Copy link
Contributor Author

Where is the best place to add a helper function to determine which identity type (comet, moon, planet, star, galaxy) we are, given c3_d *who_d? We need such a function to set the new "forwarding enabled" flag sat_u.for_o in the u3_ames struct.

@philipcmonk
Copy link
Contributor

So far we've just done u3do("clan:title", u3k(ship)). Wouldn't be hard to add a clan function (especially if we need to call it before the loom is set up), not sure where it fits, maybe vortex.c?

@matthew-levan matthew-levan force-pushed the i/492/ames-forward-iff-galaxy branch from 7661313 to 8b07e78 Compare July 12, 2023 23:41
@matthew-levan
Copy link
Contributor Author

Thanks @philipcmonk. How's this look now?

@matthew-levan matthew-levan marked this pull request as ready for review July 12, 2023 23:45
@matthew-levan matthew-levan requested a review from a team as a code owner July 12, 2023 23:45
philipcmonk
philipcmonk reviewed Jul 13, 2023
View reviewed changes
pkg/vere/io/ames.c Outdated Show resolved Hide resolved
philipcmonk
philipcmonk requested changes Jul 13, 2023
View reviewed changes
pkg/vere/io/ames.c Outdated Show resolved Hide resolved
@matthew-levan matthew-levan force-pushed the i/492/ames-forward-iff-galaxy branch from 8b07e78 to 1af525d Compare July 13, 2023 00:48
philipcmonk
philipcmonk approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@philipcmonk philipcmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matthew-levan matthew-levan merged commit e37e1f1 into develop Jul 14, 2023
@matthew-levan matthew-levan deleted the i/492/ames-forward-iff-galaxy branch July 14, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipcmonk philipcmonk philipcmonk approved these changes

@belisarius222 belisarius222 Awaiting requested review from belisarius222

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ames: forward packets iff we're a galaxy
2 participants
@matthew-levan @philipcmonk