Giving up on testing.T.TempDir oof

urfave · Jun 18, 2023 · b7064f9 · b7064f9
1 parent ce360fc
commit b7064f9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/value_source.go b/value_source.go
@@ -88,7 +88,7 @@ type fileValueSource struct {
 }
 
 func (f *fileValueSource) Lookup() (string, bool) {
- data, err := os.ReadFile(string(f.Path))
+ data, err := os.ReadFile(f.Path)
  return string(data), err == nil
 }
 

diff --git a/value_source_test.go b/value_source_test.go
@@ -4,6 +4,7 @@ import (
  "fmt"
  "math/rand"
  "os"
+ "path/filepath"
  "testing"
 
  "github.com/stretchr/testify/require"
@@ -49,10 +50,9 @@ func TestFileSource(t *testing.T) {
 func TestFilePaths(t *testing.T) {
  r := require.New(t)
 
- fileName := fmt.Sprintf("some_file_name_%[1]v", rand.Int())
+ fileName := filepath.Join(os.TempDir(), fmt.Sprintf("urfave-cli-tests-some_file_name_%[1]v", rand.Int()))
  t.Cleanup(func() { _ = os.Remove(fileName) })
 
- r.Nil(os.Chdir(t.TempDir()))
  r.Nil(os.WriteFile(fileName, []byte("Hello"), 0644))
 
  sources := Files("junk_file_name", fileName)