altsrc: Parse durations from strings

urfave · Oct 26, 2017 · d09ed35 · d09ed35
1 parent b2bf3c5
commit d09ed35
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/altsrc/map_input_source.go b/altsrc/map_input_source.go
@@ -73,15 +73,25 @@ func (fsm *MapInputSource) Duration(name string) (time.Duration, error) {
 	if exists {
 		otherValue, isType := otherGenericValue.(time.Duration)
 		if !isType {
-			return 0, incorrectTypeForFlagError(name, "duration", otherGenericValue)
+			otherStringValue, isType := otherGenericValue.(string)
+			parsedValue, err := time.ParseDuration(otherStringValue)
+			if !isType || err != nil {
+				return 0, incorrectTypeForFlagError(name, "duration", otherGenericValue)
+			}
+			return parsedValue, nil
 		}
 		return otherValue, nil
 	}
 	nestedGenericValue, exists := nestedVal(name, fsm.valueMap)
 	if exists {
 		otherValue, isType := nestedGenericValue.(time.Duration)
 		if !isType {
-			return 0, incorrectTypeForFlagError(name, "duration", nestedGenericValue)
+			otherStringValue, isType := otherGenericValue.(string)
+			parsedValue, err := time.ParseDuration(otherStringValue)
+			if !isType || err != nil {
+				return 0, incorrectTypeForFlagError(name, "duration", nestedGenericValue)
+			}
+			return parsedValue, nil
 		}
 		return otherValue, nil
 	}