Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move man page compatibility to separate package #1055

Closed
Tracked by #833
oleorhagen opened this issue Jan 28, 2020 · 6 comments · Fixed by #1779
Closed
Tracked by #833

Move man page compatibility to separate package #1055

oleorhagen opened this issue Jan 28, 2020 · 6 comments · Fixed by #1779
Assignees
Labels
area/v3 relates to / is being considered for v3 help wanted please help if you can! kind/feature describes a code enhancement / feature request status/confirmed confirmed to be valid, but work has yet to start
Milestone

Comments

@oleorhagen
Copy link
Contributor

oleorhagen commented Jan 28, 2020

What problem does this solve?

We have currently run into an issue where 30% of our binary size is the urfave/cli library. With the latest release v2 it it 50%, which for us is not going to fly.

  • Add a minimal version of the cli, using conditional compilation maybe?

Solution description

Add a minimal build flag which does not include all the external dependencies like md2man etc, and simply contains the 'core' functionality of the library.

@oleorhagen oleorhagen added area/v2 relates to / is being considered for v2 status/triage maintainers still need to look into this labels Jan 28, 2020
@asahasrabuddhe
Copy link
Member

This is an interesting observation. I think that we could look at making the library modular so that it is possible for the users to import certain modules that they want to use and ignore the others. This would considerably help in keeping the size down.

Having said that, I think this won't be possible for the v2.

But, I am glad to share with you that we are currently working on v3. I think I will add this to the list of things that we want to work on. Hopefully, very soon, you should be looking at a lean version of this library.

Thanks!

@asahasrabuddhe asahasrabuddhe added the help wanted please help if you can! label Jan 29, 2020
@coilysiren
Copy link
Member

I think if nothing else, it would be a good idea to add some stats about binary size to CI. We can do that now, and look at reducing it for V3.

@coilysiren coilysiren added status/confirmed confirmed to be valid, but work has yet to start and removed status/triage maintainers still need to look into this labels Mar 30, 2020
@stale
Copy link

stale bot commented Jun 28, 2020

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

@stale stale bot added the status/stale stale due to the age of it's last update label Jun 28, 2020
@stale
Copy link

stale bot commented Jul 29, 2020

Closing this as it has become stale.

@stale stale bot closed this as completed Jul 29, 2020
@meatballhat meatballhat reopened this Apr 22, 2022
@meatballhat meatballhat removed the status/stale stale due to the age of it's last update label Apr 22, 2022
@meatballhat meatballhat added this to the Release 2.5+ milestone Apr 22, 2022
@meatballhat meatballhat added the kind/feature describes a code enhancement / feature request label Apr 22, 2022
@meatballhat meatballhat changed the title v2 feature: ( Minimal version of the cli-library) Minimal version of the cli-library Apr 22, 2022
@dearchap
Copy link
Contributor

@meatballhat i believe we have builds which doesn't include docs

@dearchap
Copy link
Contributor

Will consider for v3 release

@meatballhat meatballhat changed the title Minimal version of the cli-library Move man page compatibility to separate package Jan 6, 2023
@meatballhat meatballhat modified the milestones: Release 2.x, Release 3.x Jan 24, 2023
@meatballhat meatballhat added area/v3 relates to / is being considered for v3 and removed area/v2 relates to / is being considered for v2 labels Jan 24, 2023
@meatballhat meatballhat self-assigned this Jun 24, 2023
meatballhat added a commit that referenced this issue Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v3 relates to / is being considered for v3 help wanted please help if you can! kind/feature describes a code enhancement / feature request status/confirmed confirmed to be valid, but work has yet to start
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants