Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow actions to return its execution status. #66

Closed
AntonioMeireles opened this issue Feb 11, 2014 · 3 comments
Closed

allow actions to return its execution status. #66

AntonioMeireles opened this issue Feb 11, 2014 · 3 comments
Labels
kind/feature describes a code enhancement / feature request

Comments

@AntonioMeireles
Copy link

Hi,

Like what is already possible for 'Before' actions, i found useful and somewhat logical to have 'Actions' return something on exit, so that app.Run() gets to catch all errors, if any, underneath it. Please look at 52496bf in case you care.

All the best

@shinpei
Copy link

shinpei commented Aug 31, 2014

+1 for this pull request. Each Action could have same type of errors, and it'd be nice to handle them at once. Or any nice solution for this issue?

@kytrinyx
Copy link
Contributor

This would be a significant breaking change, so I understand why @codegangsta would be hesitant to introduce it, even though the implementation is trivial. I've implemented the change and submitted a pull request so that if the change is desirable it can be pulled in.

@jszwedko jszwedko added the later label Feb 20, 2015
@jszwedko
Copy link
Contributor

Will try to get #66 in soon.

@meatballhat meatballhat added the kind/feature describes a code enhancement / feature request label Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature describes a code enhancement / feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants