-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix man page heading formatting #1041
Conversation
I think you should check this out https://linux.die.net/man/7/man-pages Although this page discourages adding an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some quirks of man page formatting that I haven't taken to the time look into, but this PR LGTM
Closes urfave#1040 Signed-off-by: Sascha Grunert <sgrunert@suse.com>
bce3dd0
to
5b3508d
Compare
Okay, I removed the author completely I think that might be something we can agree on. |
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
======================================
Coverage 72.6% 72.6%
======================================
Files 33 33
Lines 2482 2482
======================================
Hits 1802 1802
Misses 569 569
Partials 111 111 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What type of PR is this?
What this PR does / why we need it:
Fixing the man page header to display the section correctly
Which issue(s) this PR fixes:
Fixes #1040
Special notes for your reviewer:
None
Testing
Adapted the unit test results
Release Notes