Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] (backport) Prevent panic on flagSet access from custom BashComplete #1101

Merged
merged 1 commit into from
Mar 31, 2020
Merged

[v1] (backport) Prevent panic on flagSet access from custom BashComplete #1101

merged 1 commit into from
Mar 31, 2020

Conversation

VirrageS
Copy link

What type of PR is this?

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

See: #946. I've basically copied the code from v2 to v1 and extended the tests a little bit. All credits to the author of the fix @unRob

Which issue(s) this PR fixes:

Fixes: #1093

Special notes for your reviewer:

For more context see: #946

Release Notes

Fixed a panic with flag completion via (@unRob, @VirrageS)

@VirrageS VirrageS requested a review from a team as a code owner March 31, 2020 17:44
@VirrageS VirrageS changed the title (backport) Prevent panic on flagSet access from custom BashComplete [v1] (backport) Prevent panic on flagSet access from custom BashComplete Mar 31, 2020
@coilysiren coilysiren merged commit 053ba9d into urfave:v1 Mar 31, 2020
@coilysiren coilysiren mentioned this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants