Fix:(issue_1505) Fix flag alignment in help #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icholy
previously approved these changes
Sep 30, 2022
|
@icholy Help is very very fragile so to keep everything consistent I componentized the templates |
abitrolly
reviewed
Oct 5, 2022
julian7
previously requested changes
Oct 5, 2022
Co-authored-by: Anatoli Babenia <anatoli@rainforce.org>
meatballhat
approved these changes
Oct 6, 2022
6 tasks
another-rex
referenced
this pull request
in google/osv.dev
Oct 13, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/g-rath/osv-detector](https://togithub.com/g-rath/osv-detector) | require | minor | `v0.7.2` -> `v0.8.0` | | [github.com/urfave/cli/v2](https://togithub.com/urfave/cli) | require | minor | `v2.17.1` -> `v2.19.2` | | [golang.org/x/crypto](https://togithub.com/golang/crypto) | require | digest | `4161e89` -> `56aed06` | | [golang.org/x/exp](https://togithub.com/golang/exp) | require | digest | `b9f4876` -> `4de253d` | --- ### Release Notes <details> <summary>g-rath/osv-detector</summary> ### [`v0.8.0`](https://togithub.com/G-Rath/osv-detector/releases/tag/v0.8.0) [Compare Source](https://togithub.com/g-rath/osv-detector/compare/v0.7.2...v0.8.0) #### What's Changed - support parsing `poetry.lock`, for Python ([https://github.com/G-Rath/osv-detector/pull/156](https://togithub.com/G-Rath/osv-detector/pull/156)) - support parsing `pubspec.lock`, for Dart ([https://github.com/G-Rath/osv-detector/pull/159](https://togithub.com/G-Rath/osv-detector/pull/159)) **Full Changelog**: G-Rath/osv-detector@v0.7.2...v0.8.0 </details> <details> <summary>urfave/cli</summary> ### [`v2.19.2`](https://togithub.com/urfave/cli/releases/tag/v2.19.2) [Compare Source](https://togithub.com/urfave/cli/compare/v2.19.1...v2.19.2) #### What's Changed - fix: stop automatic sorting for --help by [@​FGYFFFF](https://togithub.com/FGYFFFF) in [https://github.com/urfave/cli/pull/1430](https://togithub.com/urfave/cli/pull/1430) #### New Contributors - [@​FGYFFFF](https://togithub.com/FGYFFFF) made their first contribution in [https://github.com/urfave/cli/pull/1430](https://togithub.com/urfave/cli/pull/1430) **Full Changelog**: urfave/cli@v2.19.1...v2.19.2 ### [`v2.19.1`](https://togithub.com/urfave/cli/releases/tag/v2.19.1) [Compare Source](https://togithub.com/urfave/cli/compare/v2.19.0...v2.19.1) #### What's Changed - Fix:(issue\_1500). Fix slice flag value duplication issue by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1502](https://togithub.com/urfave/cli/pull/1502) **Full Changelog**: urfave/cli@v2.19.0...v2.19.1 ### [`v2.19.0`](https://togithub.com/urfave/cli/releases/tag/v2.19.0) [Compare Source](https://togithub.com/urfave/cli/compare/v2.18.2...v2.19.0) #### What's Changed - Fix:(issue\_1505) Fix flag alignment in help by [@​dearchap](https://togithub.com/dearchap) in [https://github.com/urfave/cli/pull/1506](https://togithub.com/urfave/cli/pull/1506) **Full Changelog**: urfave/cli@v2.18.2...v2.19.0 ### [`v2.18.2`](https://togithub.com/urfave/cli/releases/tag/v2.18.2) [Compare Source](https://togithub.com/urfave/cli/compare/v2.18.1...v2.18.2) #### What's Changed - Configure GenericFlag's Destination type as struct not pointer by [@​nkuba](https://togithub.com/nkuba) in [https://github.com/urfave/cli/pull/1442](https://togithub.com/urfave/cli/pull/1442) #### New Contributors - [@​nkuba](https://togithub.com/nkuba) made their first contribution in [https://github.com/urfave/cli/pull/1442](https://togithub.com/urfave/cli/pull/1442) **Full Changelog**: urfave/cli@v2.18.1...v2.18.2 ### [`v2.18.1`](https://togithub.com/urfave/cli/releases/tag/v2.18.1) [Compare Source](https://togithub.com/urfave/cli/compare/v2.18.0...v2.18.1) #### What's Changed - Ensure "generate" step runs in CI prior to diff check by [@​meatballhat](https://togithub.com/meatballhat) in [https://github.com/urfave/cli/pull/1504](https://togithub.com/urfave/cli/pull/1504) **Full Changelog**: urfave/cli@v2.18.0...v2.18.1 ### [`v2.18.0`](https://togithub.com/urfave/cli/releases/tag/v2.18.0) [Compare Source](https://togithub.com/urfave/cli/compare/v2.17.2...v2.18.0) #### What's Changed - Call FlagStringer in String() method of slice flags by [@​fjl](https://togithub.com/fjl) in [https://github.com/urfave/cli/pull/1508](https://togithub.com/urfave/cli/pull/1508) #### New Contributors - [@​fjl](https://togithub.com/fjl) made their first contribution in [https://github.com/urfave/cli/pull/1508](https://togithub.com/urfave/cli/pull/1508) **Full Changelog**: urfave/cli@v2.17.2...v2.18.0 ### [`v2.17.2`](https://togithub.com/urfave/cli/releases/tag/v2.17.2) [Compare Source](https://togithub.com/urfave/cli/compare/v2.17.1...v2.17.2) #### What's Changed - Remove nonexistent phony targets by [@​meatballhat](https://togithub.com/meatballhat) in [https://github.com/urfave/cli/pull/1503](https://togithub.com/urfave/cli/pull/1503) - wrap: Avoid trailing whitespace for empty lines by [@​abitrolly](https://togithub.com/abitrolly) in [https://github.com/urfave/cli/pull/1513](https://togithub.com/urfave/cli/pull/1513) #### New Contributors - [@​abitrolly](https://togithub.com/abitrolly) made their first contribution in [https://github.com/urfave/cli/pull/1513](https://togithub.com/urfave/cli/pull/1513) **Full Changelog**: urfave/cli@v2.17.1...v2.17.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/google/osv.dev). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMjIuMyIsInVwZGF0ZWRJblZlciI6IjMyLjIzNC4yIn0=--> Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #1505
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
Release Notes
Use the user provide example
(REQUIRED)