Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to v3 #1510

Merged
merged 98 commits into from
Oct 6, 2022
Merged
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
dd9cd61
Fix for TimestampFlag.GetValue to return empty string without value
hmiyado Jul 18, 2022
67f592a
Fix HideHelp
Jul 29, 2022
02eb392
Fix After not run
Jul 28, 2022
bc99b58
issue_62: Make slice options more posix like
dearchap Aug 14, 2022
45a1375
Changes from code review
dearchap Aug 15, 2022
2ca9143
Move genflags tool to cmd/ and pin to previous release
meatballhat Aug 14, 2022
d8de3b5
Tidy up top-level go.mod
meatballhat Aug 14, 2022
a5313eb
Add missing go.sum entries for go 1.16.x
meatballhat Aug 14, 2022
cbc7f1a
Use goimports as formatting standard
meatballhat Aug 14, 2022
76bb9f1
Shift supported go versions
meatballhat Aug 14, 2022
1ae70fc
split v1 docs into individual pages
hay-kot Aug 14, 2022
edaf885
breakup v2 documentation
hay-kot Aug 14, 2022
18f8e6d
update sidebar configuration
hay-kot Aug 14, 2022
7cfafe8
add tags plugin
hay-kot Aug 15, 2022
8036eac
add tags and boost for pages
hay-kot Aug 15, 2022
d217a5a
wip: add --walk flag to gfrun to accept directory
hay-kot Aug 15, 2022
87f003f
pass in correct root
hay-kot Aug 15, 2022
2b1a8ca
rename filename to dirPath
hay-kot Aug 15, 2022
42d8058
Fix:(issue_1094) Dont execute Before/After handlers during shell comp…
dearchap Aug 18, 2022
42eb492
Rename function
dearchap Aug 18, 2022
78dac9c
Fix:(issue_1455) Allow bool flags from input altsrc
dearchap Aug 16, 2022
3c6588c
Remove debug println
dearchap Aug 23, 2022
f515798
Revert godoc changes
dearchap Aug 23, 2022
382386a
Add configurable Base to int, uint and uint64 flags
ccremer Aug 25, 2022
9de6fa4
fix: allow required flag with one character
Gerrard-YNWA Aug 14, 2022
9092325
fix: update test case
Gerrard-YNWA Aug 14, 2022
e0db267
adding in boolean alias support
james-prysm Aug 11, 2022
50bbb4a
adding string alias and test
james-prysm Aug 25, 2022
5a5789a
adding int alias and test
james-prysm Aug 25, 2022
c512a28
add support for duration flag
james-prysm Aug 25, 2022
126d238
adding float flag alias support
james-prysm Aug 25, 2022
9630e10
adding alias support to remaining flags and fixing tests
james-prysm Aug 25, 2022
9a33ae8
fixing test
james-prysm Aug 25, 2022
d520bfc
Modify nesting flag apply
Aug 30, 2022
445734d
Update v2 dead link
abousselmi Aug 30, 2022
b539ee7
Fix:(issue_1293) Wrap usage text for commands
dearchap Aug 20, 2022
d89bc4a
Change way to calculate offset
dearchap Aug 24, 2022
96e41a6
Make test case more robust
dearchap Aug 25, 2022
e48d377
Remove add function
dearchap Aug 27, 2022
321d493
Add comment
dearchap Aug 30, 2022
6331815
Add App.UnknownFlagHandler
icholy Aug 2, 2022
e19a34c
Rename App.UnknownFlagHandler to App.InvalidFlagAccessHandler
icholy Aug 8, 2022
4bce542
Traverse parent contexts
icholy Aug 15, 2022
68cd3e8
Fix:(issue_1272) Generic flag not set from env
dearchap Aug 19, 2022
d34a232
Merge remote-tracking branch 'origin/v3-dev-main' into v3-porting
meatballhat Oct 3, 2022
1446649
Use cli/v2 in genflags tool (for now?)
meatballhat Oct 3, 2022
e57f53b
Update cli.yml
sashashura Sep 2, 2022
8609031
Update version of codecov action
meatballhat Sep 5, 2022
31edfd6
Explicitly pass CODECOV_TOKEN
meatballhat Sep 5, 2022
eea567a
Add a few notes to release docs
meatballhat Sep 5, 2022
03487fc
Add count option for bool flags
dearchap Mar 23, 2021
2941bc8
Merge changes onto latest main
dearchap Aug 13, 2022
c4251de
Remove go changes
dearchap Aug 13, 2022
2b0db3b
Update for build
dearchap Aug 16, 2022
c0a2866
Merge main and run tidy
dearchap Aug 28, 2022
2f082d6
Rebase main
dearchap Sep 5, 2022
2f66431
Add to docs
dearchap Sep 5, 2022
b694a25
Update docs
dearchap Sep 5, 2022
cbd62ef
Update godocs
dearchap Sep 5, 2022
3adf8fa
Add args
dearchap Sep 5, 2022
fa3bbf9
Update docs/v2/examples/flags.md
dearchap Sep 5, 2022
c0a8506
Add context.Count
dearchap Sep 5, 2022
6b0a3e8
Add parametrize tests
dearchap Sep 5, 2022
a509290
Add countable interface
dearchap Sep 5, 2022
d58b3c7
Remove keystroke errors
dearchap Sep 6, 2022
fdcbf28
Merge changes from main
dearchap Aug 13, 2022
0764ca2
Rebase
dearchap Aug 15, 2022
7097d0e
Fix tests per latest main
dearchap Aug 15, 2022
7405a90
Fix formatting
dearchap Aug 31, 2022
9bcffd0
Merge from main
dearchap Aug 31, 2022
2a5960c
Add coverage threshold
dearchap Sep 6, 2022
5b96605
Add additional test to fix codecov
dearchap Sep 10, 2022
9c5b385
Add additional test to fix codecov
dearchap Sep 10, 2022
0658d61
Set codecov status thresholds to 5%
meatballhat Sep 10, 2022
e13c16b
Fix: dont generate pointer for dest for Generic flag
dearchap Sep 10, 2022
8e3fa06
Fix: Help name consistency among app/commands and subcommands
dearchap Sep 11, 2022
8cc0a9c
Move more functionality into internal/build/build.go
meatballhat Sep 11, 2022
d9d960a
Run make target after the Makefile is available
meatballhat Sep 11, 2022
2bec081
Use windows compatible path append
meatballhat Sep 11, 2022
0593812
Only run `make v2diff` on go `1.19.x` + `ubuntu-latest`
meatballhat Sep 11, 2022
d6c9f6a
Replace a few more custom make targets
meatballhat Sep 11, 2022
9ed5a09
Use correct env var for global flags
meatballhat Sep 11, 2022
1c3ebfa
Accept the `MKDOCS_REMOTE_GITHUB_TOKEN` var as intended
meatballhat Sep 12, 2022
d2acd0e
Fix:(issue_1197) Set destination field from altsrc for slice flags
dearchap Sep 12, 2022
e9e87f6
Add unit tests
dearchap Sep 12, 2022
a2c3729
fix: Context.Set no such flag
Sep 20, 2022
e2e14ec
feat: flag action
xwjdsh Feb 15, 2022
f9ceca5
Add more tests about flag-level action
xwjdsh Apr 30, 2022
d213683
Rebase main, update flag-spec.yaml to add Action field
xwjdsh May 22, 2022
1e30f50
make v2approve
xwjdsh Sep 15, 2022
126297a
Add more test cases
xwjdsh Sep 17, 2022
4c637d8
Fix:(issue_557) Change app help name
dearchap Aug 21, 2022
57ff098
Fix:(issue_557) Make help output consistent between different invocat…
dearchap Sep 21, 2022
c2ecb44
Remove un-needed func
dearchap Sep 21, 2022
8ef92d2
Remove un-needed func
dearchap Sep 21, 2022
5db9db6
Remove nonexistent phony targets
meatballhat Sep 29, 2022
f8faf77
Post-porting fixes for v3
meatballhat Oct 3, 2022
a851a77
Point docs tests at v3
meatballhat Oct 3, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove debug println
dearchap authored and meatballhat committed Oct 2, 2022

Verified

This commit was signed with the committer’s verified signature. The key has expired.
meatballhat Dan Buch
commit 3c6588ca75d76196b100bf012a07d7771e98e17a
3 changes: 0 additions & 3 deletions altsrc/flag.go
Original file line number Diff line number Diff line change
@@ -124,14 +124,11 @@ func (f *BoolFlag) ApplyInputSourceValue(cCtx *cli.Context, isc InputSourceConte
if f.set != nil && !cCtx.IsSet(f.Name) && !isEnvVarSet(f.EnvVars) && isc.isSet(f.BoolFlag.Name) {
value, err := isc.Bool(f.BoolFlag.Name)
if err != nil {
fmt.Println(err)
return err
}
for _, name := range f.Names() {
_ = f.set.Set(name, strconv.FormatBool(value))
}
} else {
fmt.Println("not fill")
}
return nil
}