Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run linter fixes + go mod tidy #1596

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

marwan-at-work
Copy link
Contributor

@marwan-at-work marwan-at-work commented Nov 26, 2022

I ran the linter to find functions, methods, and variables not being used as well as ran go mod tidy.

Plus, ioutil as of Go1.17 has been deprecated, so replaced all calls to os/io functions.

@marwan-at-work marwan-at-work requested a review from a team as a code owner November 26, 2022 16:37
Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I would love to see linting tooling fully integrated via CI, too, fwiw. Do you have strong opinions on what that should look like @marwan-at-work? I usually reach for golangci-lint but I admit it's been awhile since I looked around.

@marwan-at-work
Copy link
Contributor Author

marwan-at-work commented Nov 27, 2022

@meatballhat no problem! golangci sounds good to me, but hopefully we keep the rules to a minimum so new comers don't find it difficult to contribute.

Now that I have access to the merge button, I'll go ahead and push it, I think the codecov/patch is a false positive here.

Thanks!

@marwan-at-work marwan-at-work merged commit 510c407 into urfave:main Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants