Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature:(issue_351) Add support for generation of shell completion sc… #1606

Merged
merged 6 commits into from
Dec 11, 2022
Merged

Feature:(issue_351) Add support for generation of shell completion sc… #1606

merged 6 commits into from
Dec 11, 2022

Conversation

dearchap
Copy link
Contributor

@dearchap dearchap commented Nov 30, 2022 •
edited
Loading

…ripts

What type of PR is this?

(REQUIRED)

  • cleanup
  • feature

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #351

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Add new tests

go test -run=TestCompletion

Release Notes

(REQUIRED)

EnableBashCompletion has been renamed to EnableShellCompletion. When enabled completions can be generated on the fly and sourced in current shell environment

PROG=cli-app source <(cli-app generate-completion bash)

Supported shells are bash, fish, zsh, powershell

@dearchap dearchap requested a review from a team as a code owner November 30, 2022 14:24
meatballhat
meatballhat reviewed Dec 10, 2022
View reviewed changes
@dearchap dearchap requested a review from meatballhat December 11, 2022 00:00
meatballhat
meatballhat approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for progress! 🎉

@dearchap dearchap merged commit d0b8dda into urfave:main Dec 11, 2022
@davidmathers davidmathers mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meatballhat meatballhat meatballhat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for completion in other shells (fish, sh, etc.)
2 participants
@dearchap @meatballhat