Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Rename IsSliceValue to IsMultiValue #1615

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

dearchap
Copy link
Contributor

@dearchap dearchap commented Dec 5, 2022

What type of PR is this?

(REQUIRED)

  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

This is to make the interface more generic so that map types will also fall into this category

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)


@dearchap dearchap requested a review from a team as a code owner December 5, 2022 22:11
@dearchap dearchap mentioned this pull request Dec 5, 2022
Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! 🎉

@dearchap dearchap merged commit 1510efe into urfave:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants