Remove NewApp func
#1626
Merged
Remove NewApp func
#1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in favor of focusing on declarative API. Supports #1586
julian7
approved these changes
Dec 18, 2022
dearchap
reviewed
Dec 18, 2022
| @@ -574,58 +574,6 @@ func TestShowCommandHelp_CommandAliases(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestHelpNameConsistency(t *testing.T) { | |||
There was a problem hiding this comment.
It's no longer necessary or valid given that NewApp is removed
There was a problem hiding this comment.
No no no. This is to test whether the help occurs consistently between
app help cmd
app cmd help
app cmd -h
app cmd subcmd help
There was a problem hiding this comment.
dearchap
approved these changes
Dec 18, 2022
hay-kot
approved these changes
Dec 18, 2022
meatballhat
commented
Dec 18, 2022
Comment on lines
-580
to
-581
| // The inconsistency shows up when users use NewApp() as opposed to | ||
| // using App{...} directly |
There was a problem hiding this comment.
@dearchap sorry I was interpreting this comment to mean that since NewApp is removed that testing the inconsistency was no longer valid 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
in favor of focusing on declarative API.
Which issue(s) this PR fixes:
Supports #1586