Remove Author type
#1627
Closed
Remove Author type
#1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and accept strings for Authors instead Supports #1586
|
I would suggest to keep the current format. No one has complained which means that either they like it or it isnt used much. |
|
@dearchap I'm good with it staying or going, so if you'd like to see it stay 👍🏼 😁 |
|
Oops I lied! #1630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Removes the
Authortype and acceptsstrings for theAuthorsfield instead, essentially leaving any formatting considerations to whomever is using the library.Which issue(s) this PR fixes:
Supports #1586 given that the
Authortype is part of theapp.gofile which is slated for collapse intocommand.goand this type is adding very little value </opinions>