Preserve separator spec on subcommands #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The separatorSpec is not passed along to the subcommands which means that SliceFlags on subcommands will not use the global separator settings.
skelouse
approved these changes
Mar 24, 2023
meatballhat
added
kind/bug
meatballhat
changed the title
dearchap
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Aargh this comment was in my queue and didnt get submitted. @meatballhat
another-rex
referenced
this pull request
in google/osv-scanner
Mar 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/urfave/cli/v2](https://togithub.com/urfave/cli) | require | patch | `v2.25.0` -> `v2.25.1` | | [golang.org/x/exp](https://togithub.com/golang/exp) | require | digest | `642cace` -> `10a5072` | --- ### Release Notes <details> <summary>urfave/cli</summary> ### [`v2.25.1`](https://togithub.com/urfave/cli/releases/tag/v2.25.1) [Compare Source](https://togithub.com/urfave/cli/compare/v2.25.0...v2.25.1) #### What's Changed - Shift tested Go versions in v2-maint by [@​meatballhat](https://togithub.com/meatballhat) in [https://github.com/urfave/cli/pull/1692](https://togithub.com/urfave/cli/pull/1692) - Preserve separator spec on subcommands by [@​thschmitt](https://togithub.com/thschmitt) in [https://github.com/urfave/cli/pull/1710](https://togithub.com/urfave/cli/pull/1710) #### New Contributors - [@​thschmitt](https://togithub.com/thschmitt) made their first contribution in [https://github.com/urfave/cli/pull/1710](https://togithub.com/urfave/cli/pull/1710) **Full Changelog**: urfave/cli@v2.25.0...v2.25.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTQuMiJ9-->
](https://renovatebot.com){kind=link}
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The separatorSpec is not passed along to the subcommands which means that SliceFlags on subcommands will not use the global separator settings. Extended the command to pass the separatorSpec along.
Which issue(s) this PR fixes:
SliceFlags on sub commands will not use the global separator settings.
Testing
Added test case to ensure this change works as expected.
Release Notes