Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant variable declarations #1714

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Remove redundant variable declarations #1714

merged 1 commit into from
Mar 29, 2023

Conversation

huiyifyj
Copy link
Member

What type of PR is this?

  • cleanup

What this PR does / why we need it:

  • err variable is useless.
  • Reduce redundant parsed variable declaration.

@huiyifyj huiyifyj requested a review from a team as a code owner March 29, 2023 13:35
@dearchap dearchap merged commit c0cc5c2 into urfave:v2-maint Mar 29, 2023
mauromorales referenced this pull request in kairos-io/provider-kairos May 3, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/urfave/cli/v2](https://togithub.com/urfave/cli) | require
| patch | `v2.25.1` -> `v2.25.3` |

---

### Release Notes

<details>
<summary>urfave/cli</summary>

### [`v2.25.3`](https://togithub.com/urfave/cli/releases/tag/v2.25.3)

[Compare
Source](https://togithub.com/urfave/cli/compare/v2.25.2...v2.25.3)

#### What's Changed

- Fix `incorrectTypeForFlagError` for unknowns by
[@&#8203;danhunsaker](https://togithub.com/danhunsaker) in
[https://github.com/urfave/cli/pull/1708](https://togithub.com/urfave/cli/pull/1708)

#### New Contributors

- [@&#8203;danhunsaker](https://togithub.com/danhunsaker) made their
first contribution in
[https://github.com/urfave/cli/pull/1708](https://togithub.com/urfave/cli/pull/1708)

**Full Changelog**:
urfave/cli@v2.25.2...v2.25.3

### [`v2.25.2`](https://togithub.com/urfave/cli/releases/tag/v2.25.2)

[Compare
Source](https://togithub.com/urfave/cli/compare/v2.25.1...v2.25.2)

#### What's Changed

- Fix missing required flag error uses flag name and not alias by
[@&#8203;nirhaas](https://togithub.com/nirhaas) in
[https://github.com/urfave/cli/pull/1709](https://togithub.com/urfave/cli/pull/1709)
- Remove redundant variable declarations by
[@&#8203;huiyifyj](https://togithub.com/huiyifyj) in
[https://github.com/urfave/cli/pull/1714](https://togithub.com/urfave/cli/pull/1714)
- Fix:(issue 1689) Match markdown output with help output by
[@&#8203;dearchap](https://togithub.com/dearchap) in
[https://github.com/urfave/cli/pull/1723](https://togithub.com/urfave/cli/pull/1723)

#### New Contributors

- [@&#8203;nirhaas](https://togithub.com/nirhaas) made their first
contribution in
[https://github.com/urfave/cli/pull/1709](https://togithub.com/urfave/cli/pull/1709)
- [@&#8203;huiyifyj](https://togithub.com/huiyifyj) made their first
contribution in
[https://github.com/urfave/cli/pull/1714](https://togithub.com/urfave/cli/pull/1714)

**Full Changelog**:
urfave/cli@v2.25.1...v2.25.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42Ni4xIiwidXBkYXRlZEluVmVyIjoiMzUuNjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants