Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document slice flags as part of examples (v3) #1750

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

carhartl
Copy link
Member

@carhartl carhartl commented Jun 12, 2023

This PR adds an example for how to use slice flags to flags.md in the v2 docs example directory, using a StringSliceFlag in the specific example. As instructed in #1005, which seems to indicate there's some demand for it.

What type of PR is this?

  • documentation

What this PR does / why we need it:

Make the documentation more complete, so that users can get started without looking at source/tests/discussions, like me :)

Which issue(s) this PR fixes:

Fixes #1005

Release Notes

Add example for using slice flags.

@carhartl carhartl requested a review from a team as a code owner June 12, 2023 09:09
@dearchap dearchap changed the base branch from main to v2-maint June 12, 2023 10:17
@dearchap dearchap changed the base branch from v2-maint to main June 12, 2023 10:18
docs/v2/examples/flags.md Outdated Show resolved Hide resolved
@carhartl carhartl changed the base branch from main to v2-maint June 12, 2023 12:00
@carhartl carhartl changed the base branch from v2-maint to main June 12, 2023 12:02
@carhartl carhartl changed the title Document slice flags as part of examples (v2) Document slice flags as part of examples (v3) Jun 12, 2023
@carhartl carhartl force-pushed the document-slice-flags branch from 07f82dd to bc83065 Compare June 12, 2023 12:07
@carhartl carhartl force-pushed the document-slice-flags branch from bc83065 to 3cd32d8 Compare June 12, 2023 12:22
Copy link
Contributor

@dearchap dearchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @carhartl

@dearchap dearchap merged commit 1618d5c into urfave:main Jun 12, 2023
@carhartl carhartl deleted the document-slice-flags branch June 12, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 documentation: add a StringSliceFlag example to the manual
2 participants