Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename float64 types from Float64 to Float #1773

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Rename float64 types from Float64 to Float #1773

merged 2 commits into from
Jun 23, 2023

Conversation

meatballhat
Copy link
Member

What type of PR is this?

  • cleanup

What this PR does / why we need it:

Rename the types and funcs with Float64 prefix to Float prefix as described in #1759 to mimic the strconv API.

Which issue(s) this PR fixes:

Closes #1771
Closes #1772

@meatballhat meatballhat added kind/cleanup describes internal cleanup / maintaince area/v3 relates to / is being considered for v3 labels Jun 20, 2023
@meatballhat meatballhat added this to the Release 3.x milestone Jun 20, 2023
Base automatically changed from collapse-uint64-uint to main June 23, 2023 12:53
@meatballhat meatballhat marked this pull request as ready for review June 23, 2023 12:54
@meatballhat meatballhat requested a review from a team as a code owner June 23, 2023 12:54
@meatballhat meatballhat merged commit 60ceaf5 into main Jun 23, 2023
@meatballhat meatballhat deleted the rename-float64 branch June 23, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dearchap dearchap dearchap approved these changes

Assignees
No one assigned
Labels
area/v3 relates to / is being considered for v3 kind/cleanup describes internal cleanup / maintaince
Projects
None yet
Milestone
Release 3.x
2 participants
@meatballhat @dearchap