Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper messages for documenting build process #1800

Merged
merged 4 commits into from
Jul 23, 2023
Merged

Helper messages for documenting build process #1800

merged 4 commits into from
Jul 23, 2023

Commits on Jul 22, 2023

  1. Helper messages for documenting build process 

    I don't have `goimport` installed, and running `make` as described
in https://cli.urfave.org/CONTRIBUTING/#development-workflow fails.

Took this opportunity to enhance the process a bit.

I see that `zz_generated.flags.go` is invalid without `goimports`
(for whatever reason it is needed). And I need to check why
`goimports` is not installed into `./.local/bin` automatically.
    @abitrolly
    abitrolly committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    c54dfd0 View commit details
    Browse the repository at this point in the history

  2. Clarify what is generated and what is not

    @abitrolly
    abitrolly committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    fe5a43d View commit details
    Browse the repository at this point in the history

  3. Fix template indentation without goimports

    @abitrolly
    abitrolly committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    4d1267c View commit details
    Browse the repository at this point in the history

  4. Fix generator whitespaces

    @abitrolly
    abitrolly committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    648b8c6 View commit details
    Browse the repository at this point in the history