Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: show failures when running tests #873

Merged
merged 6 commits into from
Aug 24, 2019
Merged

build: show failures when running tests #873

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8469a9d
show test failures
coilysiren Aug 23, 2019
29ad6ee
DRY
coilysiren Aug 24, 2019
1095838
check length
Aug 24, 2019
7d62a9d
Merge branch 'master' into show-test-failures
Aug 24, 2019
c2d1a13
Revert "check length"
Aug 24, 2019
d3edef8
Update build.go
AudriusButkevicius Aug 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 57 additions & 11 deletions build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ import (
"bufio"
"bytes"
"fmt"
"github.com/urfave/cli"
"io/ioutil"
"log"
"os"
"os/exec"
"strings"

"github.com/urfave/cli"
)

var packages = []string{"cli", "altsrc"}
Expand Down Expand Up @@ -52,7 +53,13 @@ func main() {
}

func VetActionFunc(_ *cli.Context) error {
return exec.Command("go", "vet").Run()
cmd := exec.Command("go", "vet")

cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
coilysiren marked this conversation as resolved.
Show resolved Hide resolved

return cmd.Run()
}

func TestActionFunc(c *cli.Context) error {
Expand All @@ -67,10 +74,13 @@ func TestActionFunc(c *cli.Context) error {

coverProfile := fmt.Sprintf("--coverprofile=%s.coverprofile", pkg)

err := exec.Command(
"go", "test", "-v", coverProfile, packageName,
).Run()
cmd := exec.Command("go", "test", "-v", coverProfile, packageName)

cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr

err := cmd.Run()
if err != nil {
return err
}
Expand Down Expand Up @@ -142,16 +152,34 @@ func GfmrunActionFunc(_ *cli.Context) error {
return err
}

return exec.Command("gfmrun", "-c", fmt.Sprint(counter), "-s", "README.md").Run()
cmd := exec.Command("gfmrun", "-c", fmt.Sprint(counter), "-s", "README.md")

cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr

return cmd.Run()
}

func TocActionFunc(_ *cli.Context) error {
err := exec.Command("node_modules/.bin/markdown-toc", "-i", "README.md").Run()
cmd := exec.Command("node_modules/.bin/markdown-toc", "-i", "README.md")

cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr

err := cmd.Run()
if err != nil {
return err
}

err = exec.Command("git", "diff", "--exit-code").Run()
cmd = exec.Command("git", "diff", "--exit-code")

cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr

err = cmd.Run()
if err != nil {
return err
}
Expand All @@ -160,17 +188,35 @@ func TocActionFunc(_ *cli.Context) error {
}

func GenActionFunc(_ *cli.Context) error {
err := exec.Command("go", "generate", "flag-gen/main.go").Run()
cmd := exec.Command("go", "generate", "flag-gen/main.go")

cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr

err := cmd.Run()
if err != nil {
return err
}

err = exec.Command("go", "generate", "cli.go").Run()
cmd = exec.Command("go", "generate", "cli.go")

cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr

err = cmd.Run()
if err != nil {
return err
}

err = exec.Command("git", "diff", "--exit-code").Run()
cmd = exec.Command("git", "diff", "--exit-code")

cmd.Stdin = os.Stdin
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr

err = cmd.Run()
if err != nil {
return err
}
Expand Down