Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Flag Generation #881

Closed
wants to merge 4 commits into from
Closed

Remove Flag Generation #881

wants to merge 4 commits into from

Conversation

asahasrabuddhe
Copy link
Member

Update Travis YAML to remove generation command

Add support for Go 1.13
Drop support for Go 1.11

@asahasrabuddhe asahasrabuddhe requested a review from a team as a code owner September 7, 2019 09:08
@asahasrabuddhe
Copy link
Member Author

Looks like there is something wrong with the master as it is failing almost everything.

@codecov
Copy link

codecov bot commented Sep 7, 2019 •
edited
Loading

Codecov Report

Merging #881 into master will not change coverage.
The diff coverage is 69.04%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #881   +/-   ##
=======================================
  Coverage   71.29%   71.29%           
=======================================
  Files          18       30   +12     
  Lines        2379     2379           
=======================================
  Hits         1696     1696           
  Misses        578      578           
  Partials      105      105
Impacted Files Coverage Δ
flag.go 91.92% <ø> (+6.02%) ⬆️
docs.go 89.61% <ø> (ø) ⬆️
flag_generic.go 51.28% <51.28%> (ø)
flag_duration.go 55% <55%> (ø)
flag_uint.go 62.5% <62.5%> (ø)
flag_uint64.go 62.5% <62.5%> (ø)
flag_int64.go 65% <65%> (ø)
flag_string_slice.go 65.45% <65.45%> (ø)
flag_int64_slice.go 67.24% <67.24%> (ø)
flag_bool_t.go 70.45% <70.45%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eca109...7724f56. Read the comment docs.

@asahasrabuddhe
Update minimum supported go version to 1.11
53e8cf1 
Add support for go 1.13

seprate out the flags to individual files

fix md2man dependency issue
@asahasrabuddhe
Copy link
Member Author

Current Status:

All essential checks are passing except the diff after generating TOC since I have removed the parts of code in README.md referencing ShortOptionHandling as they are not available for use in v1.21.0

@coilysiren
Copy link
Member

All essential checks are passing except the diff after generating TOC since I have removed the parts of code in README.md referencing ShortOptionHandling as they are not available for use in v1.21.0

Can you put this inside another PR? We'll want to revert it after release 1.22.0 #867

@coilysiren
Copy link
Member

Add support for Go 1.13
Drop support for Go 1.11

I would also like for this go inside it's own PR 🙏 unless there's some specific reason it's included in this one?

@asahasrabuddhe asahasrabuddhe deleted the remove-flag-generation branch September 9, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AudriusButkevicius AudriusButkevicius Awaiting requested review from AudriusButkevicius

@coilysiren coilysiren Awaiting requested review from coilysiren

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asahasrabuddhe @coilysiren