Improve docs generation for cli.Authors #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
=======================================
Coverage 72.89% 72.89%
=======================================
Files 32 32
Lines 2439 2439
=======================================
Hits 1778 1778
Misses 550 550
Partials 111 111Continue to review full report at Codecov.
|
| % {{ .App.Author }} | ||
| var MarkdownDocTemplate = `% {{ .App.Name }}(8){{ if .App.Description }} {{ .App.Description }}{{ end }} | ||
| {{ range $a := .App.Authors }} | ||
| % {{ $a }}{{ end }} |
There was a problem hiding this comment.
Whst if authors is not set just author, that would be confusing as it would not work.
There was a problem hiding this comment.
I thought this will catch it, doesn't it?
Lines 142 to 144 in 63cd2e3
|
@AudriusButkevicius may I ping you to merge this or review it again please? =) |
|
PR has merge conflicts now! |
saschagrunert
force-pushed
the
author-improvement
branch
from
c0d01ac
to
995604f
Compare
This allows specifying multiple authors, whereas no available authors will be formatted correctly now. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
saschagrunert
force-pushed
the
author-improvement
branch
from
995604f
to
2cb62f5
Compare
|
Rebased on top of the master branch, please take a look 🙏 |
coilysiren
approved these changes
Nov 14, 2019
AudriusButkevicius
approved these changes
Nov 14, 2019
Merged
This was referenced May 21, 2021
Closed
This was referenced Jun 6, 2021
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying multiple authors, whereas no available authors
will be formatted correctly now.