Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in DocGenerationFlag.TakesValue() docstring #902

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

benmoose
Copy link
Contributor

@benmoose benmoose commented Sep 28, 2019

Just fixes a little typo

@benmoose benmoose requested a review from a team as a code owner September 28, 2019 18:03
@benmoose benmoose changed the title Fix typo in flag.go docstring Fix typo in DocGenerationFlag.TakesValue() docstring Sep 28, 2019
@codecov
Copy link

codecov bot commented Sep 28, 2019

Codecov Report

Merging #902 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files          30       30           
  Lines        2393     2393           
=======================================
  Hits         1710     1710           
  Misses        577      577           
  Partials      106      106
Impacted Files Coverage Δ
flag.go 91.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b59274...d509d6b. Read the comment docs.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@coilysiren coilysiren merged commit 63cd2e3 into urfave:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants