Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix zsh autocomplete #906

Merged
merged 1 commit into from
Oct 9, 2019
Merged

fix zsh autocomplete #906

merged 1 commit into from
Oct 9, 2019

Conversation

fawaf
Copy link
Contributor

@fawaf fawaf commented Oct 6, 2019

No description provided.

@fawaf fawaf requested a review from a team as a code owner October 6, 2019 08:59
@codecov
Copy link

codecov bot commented Oct 6, 2019 •
edited
Loading

Codecov Report

Merging #906 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #906   +/-   ##
=======================================
  Coverage   71.45%   71.45%           
=======================================
  Files          30       30           
  Lines        2393     2393           
=======================================
  Hits         1710     1710           
  Misses        577      577           
  Partials      106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63cd2e3...e19c344. Read the comment docs.

saschagrunert
saschagrunert reviewed Oct 6, 2019
View reviewed changes
autocomplete/zsh_autocomplete
@@ -1,3 +1,5 @@
#compdef $PROG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gnowxilef, can you please explain a bit how this fixes the ZSH completion?

Copy link
Contributor Author

@fawaf fawaf Oct 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, on the zsh documentation page http://zsh.sourceforge.net/Doc/Release/Completion-System.html#Initialization under the "Autoloaded files" section (20.2.2), it states that adding #compdef name will make the completion file autoloadable. the current behavior of the cli does not load anything into zsh.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@coilysiren coilysiren merged commit 2794317 into urfave:master Oct 9, 2019
@coilysiren coilysiren mentioned this pull request Nov 18, 2019
Merged
@fawaf fawaf mentioned this pull request Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coilysiren coilysiren coilysiren approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fawaf @saschagrunert @coilysiren