timestamp flag

[drov0]

Fixes #696

Changes

This is a simple flag to add the support for timestamps. At first this flag was using protobuf timestamps but I ended up editing it since I figured you would be more interested in something more general. But if you guys are interested I would love to make a protobuf timestamp as well. (saves a few lines on my app code)

Reviewer Guidelines

I'm not sure if this code works with env variables. I tried to take inspiration from int64_slice and string_slice since those were the only flag that didn't use the default set from golang's Flag

I am open to any changes you see fit.

[asahasrabuddhe]

Please add test cases to test the new functionality. Also update the manual.md to reflect the new features.

[drov0]

@asahasrabuddhe

update the manual.md to reflect the new features.

Which part of the manual.md ? The full example ? There isn't much details on specific flags on the manual, It seems like most of the doc is auto generated through GoDoc

[asahasrabuddhe]

@asahasrabuddhe

update the manual.md to reflect the new features.

Which part of the manual.md ? The full example ? There isn't much details on specific flags on the manual, It seems like most of the doc is auto generated through GoDoc

What I meant was that you add an example of using the timestamp flag as I think this is a unique flag, and users would appreciate an example on how to use it in their application.

[asahasrabuddhe]

@drov0 If I initialize a timestamp flag without any default layout value, what layout is considered for the flag? Do you think having a default out of the box value for the layout would help?

[asahasrabuddhe]

@drov0 If I initialize a timestamp flag without any default layout value, what layout is considered for the flag? Do you think having a default out of the box value for the layout would help?

[drov0]

@asahasrabuddhe, okay for the manual, will add on monday. As for the layout It won't work if you don't set it, the layout is mandatory. I considered having a default value but since there are so many different layouts, I figured that people would almost always use a custom layout anyways. Kind of like time.Parse doesn't have a default layout.

[asahasrabuddhe]

@asahasrabuddhe, okay for the manual, will add on monday. As for the layout It won't work if you don't set it, the layout is mandatory. I considered having a default value but since there are so many different layouts, I figured that people would almost always use a custom layout anyways. Kind of like time.Parse doesn't have a default layout.

Fair enough. I think once we have an example, we are good to go 👍

[drov0]

@asahasrabuddhe I added examples at the end in the full example, is that ok or would you rather that I add a complete new section for it ?

[keyoub]

@drov0 thanks for adding this feature.

@lynncyrin any chance we can get this into a minor release (2.0.1 perhaps)? Would love to use the timestamp flag in my application with the proper go.mod routine.

[coilysiren]

I'll draft a release soon 👍

[coilysiren]

=> #1013

[coilysiren]

It's released 🚢 => https://github.com/urfave/cli/releases/tag/v2.1.0