Fix some golint errors #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liam Hampton <liam.hampton@ibm.com>
Signed-off-by: Liam Hampton <liam.hampton@ibm.com>
coilysiren
approved these changes
Dec 13, 2019
saschagrunert
approved these changes
Dec 13, 2019
rliebz
approved these changes
Dec 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
=======================================
Coverage 73.38% 73.38%
=======================================
Files 32 32
Lines 2435 2435
=======================================
Hits 1787 1787
Misses 539 539
Partials 109 109
Continue to review full report at Codecov.
|
Merged
This was referenced May 21, 2021
Closed
This was referenced Jun 1, 2021
Closed
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After searching the code for some feature clarity during my daily development I was faced with a few linter errors in my IDE. A couple of them seemed to be a fairly easy fix. This will also help boost the go report percentage for
golint.Changes
Add comments to interfaces missing them and fix what looks to be a typo in
flag_path.go. Also added a simple format change to keep it consistent with the rest of the code.Testing
This change will not effect any functionality. No test required.
Reviewer Guidelines
I think these comments looks reasonable but if there are any issues I'd be happy to change them :)
Signed-off-by: Liam Hampton liam.hampton@ibm.com