Automatically Build Project#13
Closed
ArcticLight wants to merge 2 commits intourgrue:masterfrom
ArcticLight:master
Closed
Automatically Build Project#13ArcticLight wants to merge 2 commits intourgrue:masterfrom ArcticLight:master
ArcticLight wants to merge 2 commits intourgrue:masterfrom
ArcticLight:master
Conversation
added 2 commits
January 31, 2016 02:32
Open
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I really like your library; I think it's great that something like this exists, however it's not terribly easy to include in a personal project because it doesn't appear to be anywhere on Maven and wasn't immediately compatible with jitpack.io because of its dependency on one of your other projects.
It turns out that this is really easy to fix though, because you use Maven in your projects (P.s. thanks for that, you're awesome!). If you add the Jitpack service as a dependency, you can directly get the async-http-client jar from your Github instead of users having to download it themselves.
This makes it so that instead of manually downloading all of your project dependencies, anyone interested in your project can include it via Maven dependency, because jitpack.io will package it in a jar. Overall, this makes it easier to use your code because I don't have to manage the jars manually, and can rely on the regular Maven process.
This pull request contains the minimum changes to make this magic happen, which is really just like 6 lines of code changed in your pom.xml, if you just want to accept the PR. If you don't want to do that, that's fine too, just reject the pull request. But support for all of your dependencies being right there would be very helpful <3