Adding gradle build and 'async-http-client' jar as dependency#20
Closed
nhutniak wants to merge 1 commit intourgrue:masterfrom
Closed
Adding gradle build and 'async-http-client' jar as dependency#20nhutniak wants to merge 1 commit intourgrue:masterfrom
nhutniak wants to merge 1 commit intourgrue:masterfrom
Conversation
Owner
|
I sincerely appreciate the contribution and apologize for not responding sooner. The current plan is to move to a more robust and tested http client along w/ v5 support. After that, I'll gladly take a look at gradle support, and be willing to accept a future PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the gradle portion was in your roadmap so I added it for you.
Unfortunately I needed to commit the async jar to the project. If you make the other project accessible as a jar via maven central then it's easy to remove the jar and switch the gradle dependency.